run code to build cfg template earlier - #320
Open
Christian-B wants to merge 1 commit into
Open
Conversation
rowleya
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reminder.
To support unittests that call sim.setup() but do not use any cfg values we delayed when we check if the user has created their cfg and if not write the template.
This is done by storing __missing_config_file during sim.setup.
previously.
the check_user_cfg method which creates the template was called if transceiver creation failed.
but we before we get there we have to get the machine version
SO:
This pr also calls it if version_factory fails.