docs: cut release branch and tag from master, not the feature branch - #708
Open
likhithThammegowda wants to merge 1 commit into
Open
docs: cut release branch and tag from master, not the feature branch#708likhithThammegowda wants to merge 1 commit into
likhithThammegowda wants to merge 1 commit into
Conversation
The runbook contradicted itself: one line said to cut release artifacts from the merged trunk commit, another said a release run could create the branch and tag before the master merge. Following the second produced 4.2.9 and 4.2.11 as release branches pointing at fix-branch commits, so the deployed artifact was not reachable from master. State the rule once, with the commands, and record that master needs two approving reviews and cannot be merged programmatically — so the flow stops at the PR and the branch/tag come afterwards, from master. Also adds the --title "Release-X.Y.Z" flag that the documented gh command was missing; without it the release title defaults to the tag name.
Santhoshshivaprakash
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only. No release notes — this isn't being released.
Problem
The release runbook contradicted itself. One line said to cut release artifacts from the merged trunk commit; another said a release run could create the GitHub Release and the branch/tag before the master merge. Following the second reading produced
release-4.2.9andrelease-4.2.11as branches pointing at fix-branch commits, so the deployed artifact was not reachable frommaster— it diverged from the trunk and from what reviewers approved.Change
release-X.Y.ZandvX.Y.Zare always cut frommaster, never from the feature/fix branch, with the exact commands.masterrequires 2 approving reviews and cannot be merged programmatically (the API returns405), so automation stops at opening the PR.--title "Release-X.Y.Z"flag the documentedgh release createcommand was missing — without it the release title defaults to the tag name, which is not the convention.release-4.2.9andrelease-4.2.11are left as published; the rule applies from 4.2.12 onward.