fix(ui-tui): Shift+Enter inserts newline instead of submitting#1
Open
Speedway1 wants to merge 1 commit into
Open
fix(ui-tui): Shift+Enter inserts newline instead of submitting#1Speedway1 wants to merge 1 commit into
Speedway1 wants to merge 1 commit into
Conversation
Patch ink-text-input to only submit on plain Enter; Shift+Enter now inserts a newline (consistent with Alt+Enter). Added patch-package with postinstall hook so the patch survives npm install.
Speedway1
pushed a commit
that referenced
this pull request
May 16, 2026
…ssthrough, framenavigated relocation CRITICAL (Critic Finding #1): PulseAudio mute/unmute helpers defaulted to 'tess_mic_*' but AudioBridge creates 'hermes_meet_*' — entire mute/unmute lifecycle was a silent no-op. Now passes actual device names from bridge_info through TessRealtimeSession.__init__() → speak(). HIGH (Critic Finding NousResearch#3): framenavigated handler registered before page.goto() could false-trigger on initial navigation with edge-case meeting URLs. Moved registration to AFTER page.goto() completes. Review: Heterogeneous 5-Agent protocol — Architect (GLM 5.1), Critic (Minimax M2.7), Alternative (Kimi K2.6, timed out). 16 total findings, 2 CRITICAL fixed immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the Hermes TUI,
Alt+Entercorrectly inserts a newline in the text input, butShift+Enterwas incorrectly submitting the message instead.This PR makes
Shift+Enterinsert a newline (likeAlt+Enter) and limits plainEnterto submission only.Changes
[email protected](ui-tui/node_modules/ink-text-input/build/index.js): Added!key.shiftguard to thekey.returnsubmit handler so Shift+Enter falls through to the newline-insertion path.patch-packagefor reproducible patching acrossnpm installruns.ui-tui/package.json: Addedpostinstall: patch-packagescript.Technical detail
ink-text-input'suseInputhandler had:Now:
Testing
Verified manually in the Hermes TUI:
Entersubmits the messageShift+Enterinserts a newlinepatch-packageapplies cleanly afternpm install