Skip to content

fix: quota scopes#128

Merged
ngovinh2k2 merged 2 commits into
devfrom
fix/quota-scopes
Jul 17, 2026
Merged

fix: quota scopes#128
ngovinh2k2 merged 2 commits into
devfrom
fix/quota-scopes

Conversation

@ngovinh2k2

Copy link
Copy Markdown
Member

What?

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the device quota and downgrade task to use the FeatureCode and FeatureUsageScope constants instead of hardcoded strings. A critical issue was identified in the downgrade task where using the FeatureCode Enum directly as a key lookup in the limits dictionary will fail, because the dictionary keys are serialized as strings when passed through Celery. It is recommended to use .value to access the underlying string representation of the Enum.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/device/tasks.py
@ngovinh2k2
ngovinh2k2 merged commit e1cecce into dev Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant