Skip to content

chore: show deactivated devices#127

Merged
lethanhdat762003 merged 2 commits into
devfrom
chore/show-deactivated-devices
Jul 16, 2026
Merged

chore: show deactivated devices#127
lethanhdat762003 merged 2 commits into
devfrom
chore/show-deactivated-devices

Conversation

@lethanhdat762003

Copy link
Copy Markdown
Member

What?

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the is_deactivated field to the DeviceSerializer metadata fields. However, the reviewer noted that this field is not defined on the underlying Device model or within the serializer itself, which will cause Django Rest Framework to raise an AssertionError during initialization. The field needs to be properly defined to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/device/serializers.py
@lethanhdat762003
lethanhdat762003 merged commit d609885 into dev Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants