chore: get public device for smart building#124
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the conditional check for the organization template when listing space devices, making the retrieval of combined results unconditional. The reviewer identified that this change introduces severe performance issues by bypassing database-level pagination and loading all records into memory. Additionally, it incorrectly exposes public devices to all organization templates. The reviewer recommends restoring the template check and expanding it to include both smart fleet monitor and smart building templates.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
What?
Get public device for smart building
Why?
How?
Testing?
Anything Else?