Skip to content

chore: get public device for smart building#124

Merged
ngovinh2k2 merged 1 commit into
devfrom
chore/get-public-device-for-smart-building
Jul 3, 2026
Merged

chore: get public device for smart building#124
ngovinh2k2 merged 1 commit into
devfrom
chore/get-public-device-for-smart-building

Conversation

@ngovinh2k2

Copy link
Copy Markdown
Member

What?

Get public device for smart building

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the conditional check for the organization template when listing space devices, making the retrieval of combined results unconditional. The reviewer identified that this change introduces severe performance issues by bypassing database-level pagination and loading all records into memory. Additionally, it incorrectly exposes public devices to all organization templates. The reviewer recommends restoring the template check and expanding it to include both smart fleet monitor and smart building templates.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/device/views.py
Comment thread apps/device/views.py
@ngovinh2k2
ngovinh2k2 merged commit d06b1b3 into dev Jul 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants