Skip to content

feat: downgrade subscription when its expired#130

Merged
lethanhdat762003 merged 5 commits into
devfrom
feat/downgrading-subscription
Jul 16, 2026
Merged

feat: downgrade subscription when its expired#130
lethanhdat762003 merged 5 commits into
devfrom
feat/downgrading-subscription

Conversation

@lethanhdat762003

Copy link
Copy Markdown
Member

What?

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a background consumer to handle organization downgrade events and deactivate excess spaces, alongside some cleanup of unused imports. However, several critical issues were identified: removing console_client from views will cause NameErrors because it is still in use; the space deactivation logic has bugs regarding incorrect field filtering, missing tenant schema context, and inefficient QuerySet evaluation; and running the consumer in the background of the Docker entrypoint is a container anti-pattern that should be avoided in favor of a separate service.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/authentication/views.py
Comment thread apps/space/views.py
Comment thread apps/space/consumers.py Outdated
Comment thread docker-entrypoint.sh Outdated
@lethanhdat762003
lethanhdat762003 force-pushed the feat/downgrading-subscription branch from c447a9e to 3b52fa1 Compare July 15, 2026 08:06
Comment thread apps/authentication/views.py
Comment thread apps/space/tasks.py Outdated
Comment thread apps/space/views.py
@lethanhdat762003
lethanhdat762003 merged commit ed1511d into dev Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants