Added myself to contributors #1 and #6 - #8
Open
Kapoor-Tushar wants to merge 5 commits into
Open
Conversation
In this code, I have considered index.html file present in public folder to be the initial Structure for the HTML file. Code is divided into following factors:- 1) Removing noscript tag to enable script as index.html file present in public folder contains this tag. 2)Creating a button and then adding the class and name to it. 3) Adding a link to the button when it is clicked. Note - Here the link that I have added is the Dev Nation contributor page that you have created.
In respect to the file (Contributors-HomeButton.js), I have added the styles to the button created in the js file. Changes done by me are following:- 1) Made changes in btn class which was in created in Contributors-HomeButton.js. 2) Added Effects it make it look good.
Author
|
Hi! SoundaryKhanapur, Please look into the code and if you feel that the code will work for you please accept the pull request.😊 |
Kapoor-Tushar
changed the title
Owner
|
Hey, please could you create separate pull requests for the two tasks? |
|
Use this branch for latest changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have successfully added my details to contributorData, added Home Button and styled the Home button. This is my first pull request hope you would accept it.🙂