Skip to content

Add beta Bazel JVM manifest support#1312

Merged
Simon (simonhj) merged 14 commits into
v1.xfrom
simon/bazel-manifest-cli
May 18, 2026
Merged

Add beta Bazel JVM manifest support#1312
Simon (simonhj) merged 14 commits into
v1.xfrom
simon/bazel-manifest-cli

Conversation

@simonhj
Copy link
Copy Markdown

@simonhj Simon (simonhj) commented May 13, 2026

Summary

Adds beta Bazel JVM SBOM support to Socket CLI.

Bazel is multi-language, but this PR starts with Bazel + Maven because many Bazel JVM repos declare Maven dependencies through rules_jvm_external in MODULE.bazel or WORKSPACE instead of committing a manifest Socket can already scan. The extractor asks Bazel what Maven artifacts it resolved, converts that into a maven_install.json-shaped manifest, and sends it through the existing scan pipeline.

What changed

  • Adds socket manifest bazel [beta], a generation-only command for producing Bazel JVM SBOM manifests.
  • Extends socket scan create --auto-manifest so Bazel workspaces are detected automatically and scanned through the normal scan-create flow.
  • Detects Bazel workspaces via MODULE.bazel, WORKSPACE, or WORKSPACE.bazel.
  • Supports Bzlmod and legacy WORKSPACE invocation modes.
  • Discovers Maven repos from Bazel-visible repos / workspace metadata, including custom repo names beyond @maven.
  • Parses jvm_import and aar_import rules from bazel query --output=build.
  • Uses unsorted_deps.json when available as a faster structured source.
  • Writes auto-manifest output under .socket-auto-manifest/maven_install.json so we do not overwrite a repo's checked-in maven_install.json.
  • Adds docs, changelog entry, socket.json defaults, fixtures, and test coverage.

User flow

Generate only:

socket manifest bazel .

Generate and upload in one step:

socket scan create --auto-manifest .

Testing

Tested with unit and integration coverage for:

  • Bazel binary resolution.
  • Bzlmod vs legacy WORKSPACE detection.
  • Bazel query argv construction.
  • Maven repo discovery, including custom repo names and multi-repo cases.
  • jvm_import / aar_import parsing.
  • unsorted_deps.json parsing.
  • Normalization into maven_install.json.
  • Auto-manifest dispatch and .socket-auto-manifest/ output behavior.

Also tested against a corpus of Bazel repositories covering constructed and real-world Maven extraction cases, Bzlmod, legacy WORKSPACE, custom repo names, pinned and unpinned lockfile flows, and scan-create auto-manifest behavior.

Local checks:

git diff --check origin/v1.x
pnpm check:tsc
pnpm exec eslint --report-unused-disable-directives eslint.config.js src/commands/fix/coana-fix.mts src/commands/manifest src/commands/scan/handle-create-new-scan.mts src/commands/scan/handle-create-new-scan.test.mts src/utils/socket-json.mts vitest.config.mts
pnpm exec vitest run src/commands/manifest/bazel/bazel-bin-detect.test.mts src/commands/manifest/bazel/bazel-build-parser.test.mts src/commands/manifest/bazel/bazel-java-shim.test.mts src/commands/manifest/bazel/bazel-output-base-check.test.mts src/commands/manifest/bazel/bazel-python-shim.test.mts src/commands/manifest/bazel/bazel-query-runner.test.mts src/commands/manifest/bazel/bazel-repo-discovery.test.mts src/commands/manifest/bazel/bazel-workspace-detect.test.mts src/commands/manifest/bazel/cmd-manifest-bazel.test.mts src/commands/manifest/bazel/extract_bazel_to_maven.test.mts src/commands/manifest/bazel/generate_auto_manifest.bazel.constructed.test.mts src/commands/manifest/detect-manifest-actions.test.mts src/commands/manifest/generate_auto_manifest.test.mts src/commands/manifest/cmd-manifest.test.mts src/commands/scan/handle-create-new-scan.test.mts

Note

Medium Risk
Adds a new Bazel-based manifest generation pipeline that shells out to bazel/bazelisk, reads workspace outputs, and feeds generated files into scan create target discovery; failures or environment differences (Java/Python/Bazel setup, permissions, timeouts) could impact scan creation behavior.

Overview
Adds beta Bazel JVM SBOM support via a new socket manifest bazel subcommand that discovers rules_jvm_external Maven repos (Bzlmod and legacy WORKSPACE), runs Bazel queries / reads unsorted_deps.json, and normalizes the results into a maven_install.json-shaped manifest.

Extends socket scan create --auto-manifest to detect Bazel workspaces (MODULE.bazel, WORKSPACE, WORKSPACE.bazel), generate the Bazel manifest into a sidecar directory, and include those generated files in subsequent scan file discovery.

Introduces Bazel-specific hardening and plumbing (bazel binary resolution, Java/Python prerequisites, --output_base validation, bounded parsers/DoS guards), plus new socket.json defaults, docs/changelog updates, fixtures, and broad unit/integration test coverage.

Reviewed by Cursor Bugbot for commit 28ad5cb. Configure here.

Copy link
Copy Markdown
Contributor

@mtorp Martin Torp (mtorp) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏

Comment thread src/commands/manifest/bazel/extract_bazel_to_maven.constructed.test.mts Outdated
Comment thread src/commands/manifest/README.md Outdated
Comment thread src/commands/manifest/bazel/bazel-query-runner.mts
Comment thread src/commands/manifest/bazel/bazel-build-parser.mts Outdated
- Remove three integration test files that depend on ~/src/bazel-bench,
  a local fixture not available to open-source users
- Drop --json and --markdown from the manifest bazel README options
  since those flags are not implemented for this subcommand
- Add a 10-minute timeout to bazel spawn calls to prevent CI hangs
  on cold-cache or stalled bazel server invocations
- Cache per-attr and per-tag-key regexes at module level in
  bazel-build-parser to avoid recompiling on every rule block
@simonhj Simon (simonhj) marked this pull request as ready for review May 16, 2026 12:34
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 4 potential issues.

Fix All in Cursor

Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issues.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 28ad5cb. Configure here.

Comment thread src/commands/manifest/bazel/bazel-output-base-check.mts Outdated
Comment thread src/commands/manifest/bazel/extract_bazel_to_maven.mts Outdated
Comment thread src/commands/manifest/bazel/bazel-repo-discovery.mts Outdated
Comment thread src/commands/manifest/bazel/bazel-output-base-check.test.mts
Replaces ad-hoc (e as Error).message casts and instanceof Error
ternaries with getErrorCause from utils/errors.mts in three catch
blocks across bazel-output-base-check, bazel-repo-discovery, and
extract_bazel_to_maven.
Resolves CHANGELOG.md conflict by preserving the Unreleased Bazel
entries above the 1.1.94/1.1.95/1.1.96 releases that landed on v1.x
while this PR was open.
Satisfies the import-x/order lint rule by moving the
../../../utils/errors.mts import after the local ./bazel-* siblings.
@simonhj Simon (simonhj) merged commit 6a005ac into v1.x May 18, 2026
12 checks passed
@simonhj Simon (simonhj) deleted the simon/bazel-manifest-cli branch May 18, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants