fix(release): sync rust/Cargo.lock in version:bump (stop kind-deploy-smoke drift)#111
Merged
Conversation
…smoke drift) sync-versions.mjs stamped every published member Cargo.toml [package] version on a release but never touched rust/Cargo.lock — so the lockfile pinned the OLD versions and cargo build --locked (kind-deploy-smoke + every release cargo publish) refused to build until someone hand-synced it (bit #85, #108). Now the script also stamps the lock: bump the version of each [[package]] whose name is one of the lockstep published members (NOT -core, NOT the non-published lambda/examples at 0.1.0). Verified by simulating a 1.8.0 release → toml + lock advance together → --locked builds; lambda stays 0.1.0, core stays 0.14.1. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01U7Mn93HpqhSgEmX6tRdPAv
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permanently fixes the recurring Cargo.lock drift that broke
kind-deploy-smokeafter every 🦋 release (hand-synced in #85 and #108).Root cause:
scripts/sync-versions.mjs(run byversion:bumpright afterchangeset version) stamps the anchor version onto every published member’sCargo.toml[package] version, but never updatesrust/Cargo.lock. So the lock pins the OLD versions, andcargo build --locked(kind-deploy-smoke + every releasecargo publish) refuses to build until someone hand-runscargo update --workspace.Fix: the script now also stamps the lock — bumping the
versionof each[[package]]whose name is one of the lockstep published members. It keys off the exact published-crate set (derived from the member Cargo.tomls), NOT a broadsmooai-smooth-operator*match, so it leaves-core(own 0.14 cadence) and the non-published…-lambda/examples (0.1.0) alone — bumping those would re-break--locked. String-stamping (vs shelling out tocargo update) avoids the CI failure mode where the siblingsmooth-operator-corepath dep is absent.Verified: simulated a 1.8.0 release →
Cargo.toml+Cargo.lockadvance together →cargo build --lockedbuilds;…-lambdastays 0.1.0,…-corestays 0.14.1.🤖 Generated with Claude Code