MS-1502 Refactor Life feedback fragment to have a single UI state

[luhmirin-s]

JIRA ticket
Will be released in: 2026.3.0

Notable changes

• Refactored live feedback fragment/vm to have a single observable UI state source in the VM that is deterministically rendered by the fragment. There are couple of UI interactions driven purely by fragment (e.g. permission and torch) that are not worth bringing into vm flow at the moment.
• Consolidated all live feedback tests into a single file.

Testing guidance

• Run regular face capture flows (or even testiny cases)

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

This PR refactors the face live-feedback capture screen to use a single, immutable UI state (LiveFeedbackState) exposed from the ViewModel via StateFlow, with the fragment rendering deterministically from that state. It also removes the legacy BAD_QUALITY face-detection status from capture logic/tests and deprecates the corresponding face-capture event result.

Changes:

• Replaced multiple LiveData streams in the live-feedback ViewModel/fragment with a single StateFlow<LiveFeedbackState> and state-driven rendering.
• Removed FaceDetection.Status.BAD_QUALITY and stopped emitting FaceCapturePayload.Result.BAD_QUALITY (now deprecated in event model).
• Consolidated/rewrote live-feedback ViewModel tests into a single behavior-pinning test file and updated related capture tests.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
infra/events/src/main/java/com/simprints/infra/events/event/domain/models/FaceCaptureEvent.kt	Deprecates the legacy BAD_QUALITY event result value.
face/capture/src/main/java/com/simprints/face/capture/models/FaceDetection.kt	Removes BAD_QUALITY from detection statuses.
face/capture/src/main/java/com/simprints/face/capture/usecases/SimpleCaptureEventReporter.kt	Stops mapping capture status to BAD_QUALITY payload results.
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackViewModel.kt	Refactors to single-source-of-truth StateFlow state, removes runBlocking, and drives UI via emitted state snapshots.
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackState.kt	Introduces immutable UI state + progress model + status→feedback mapping.
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt	Renders from LiveFeedbackState and collects state with repeatOnLifecycle.
face/capture/src/test/java/com/simprints/face/capture/usecases/SimpleCaptureEventReporterTest.kt	Updates expectations to match removal of BAD_QUALITY reporting.
face/capture/src/test/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackViewModelTest.kt	New consolidated tests for the refactored single-state ViewModel.
face/capture/src/test/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragmentViewModelTest.kt	Removes legacy tests for the old ViewModel shape.
face/capture/src/test/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackAutoCaptureFragmentViewModelTest.kt	Removes legacy auto-capture tests for the old ViewModel shape.
face/capture/src/test/java/com/simprints/face/capture/screens/FaceCaptureViewModelTest.kt	Initializes the Face BioSDK in tests to align with updated ViewModel behavior.

Comments suppressed due to low confidence (1)

face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackViewModel.kt:105

• emit()'s parameters are non-nullable, so the Elvis operators (phase ?: ..., feedback ?: ..., result ?: ...) are dead code and will always pick the left-hand side. This adds noise and can mask intent (e.g., if the goal was to allow passing null to keep existing state).

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud