Fixes for 2d struct simulation #562
Open
ktbolt wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
I will add a test for this. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 69.04% 69.07% +0.02%
==========================================
Files 181 181
Lines 34121 34132 +11
Branches 5897 5901 +4
==========================================
+ Hits 23560 23577 +17
+ Misses 10424 10417 -7
- Partials 137 138 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hanzhao2020
reviewed
Jun 3, 2026
hanzhao2020
approved these changes
Jun 4, 2026
Contributor
hanzhao2020
left a comment
There was a problem hiding this comment.
@ktbolt Looks good to me, thanks for making these changes!
Collaborator
Author
|
@divya-adil Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed some indexing and an Eigen error in material models (#557).