New Image component (2023-04)#787
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
lordofthecactus
force-pushed
the
Image-23-04
branch
2 times, most recently
from
4853bd0 to
d357a01
Compare
cartogram
reviewed
Apr 17, 2023
Co-authored-by: Matt Seccafien <[email protected]>
Co-authored-by: Matt Seccafien <[email protected]>
Co-authored-by: Matt Seccafien <[email protected]>
lordofthecactus
force-pushed
the
Image-23-04
branch
from
e46cf3c to
f7de5ce
Compare
Member
Author
There was some issue with #649 that wasn't building properly on 2023-04 — and so @lordofthecactus and I figured the simplest thing in the end, after a bunch of trial and error, was to just copy/paste and do a new PR rebased on top of 2023-04. |
Closed
Closed
frandiox
pushed a commit
that referenced
this pull request
Jun 16, 2026
* Creates new Image on top of 2023-04 Co-authored-by: Matt Seccafien <[email protected]> * Adds changeset * Fix tests * Builds docs * update changesets to major * Update .changeset/thirty-rice-sin.md Co-authored-by: Matt Seccafien <[email protected]> * fix docs * Apply suggestions from code review Co-authored-by: Matt Seccafien <[email protected]> * Add default width to and update docs * Updates Image component and reverts collection template * Remove todo from demo store * simplify collection card image implementation * Updates changeset --------- Co-authored-by: Matt Seccafien <[email protected]> Co-authored-by: Daniel Rios Pavia <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #649