[Refactor] Use uniq and flatMap in app-management-client.ts#7785
[Refactor] Use uniq and flatMap in app-management-client.ts#7785gonzaloriestra wants to merge 1 commit into
Conversation
Refactor the `allowedTemplates` function in `packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts` to use `uniq` from `@shopify/cli-kit/common/array` and `.flatMap()` instead of manual `Set` deduplication.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This refactor improves code readability and maintainability by using project-standard utility functions for array deduplication and flattening.
WHAT is this pull request doing?
Refactors the
allowedTemplatesfunction inpackages/app/src/cli/utilities/developer-platform-client/app-management-client.tsto:uniqhelper from@shopify/cli-kit/common/arrayinstead of manualArray.from(new Set(...))construction.flatMapinstead ofmap(...).flat().How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 8031308280060896414 started by @gonzaloriestra