Hough line & circle detection, Harris corner detection#53
Open
ShaharMS wants to merge 30 commits into
Open
Conversation
Plan: .github/plans/hough-harris-feature-detection-1-foundation.md Pass: initial implementation
Plan: .github/plans/hough-harris-feature-detection-1-foundation.md Pass: review follow-up
Plan: .github/plans/hough-harris-feature-detection-1-foundation.md Pass: metadata-only review follow-up
Plan: .github/plans/hough-harris-feature-detection-1-foundation.md Pass: review follow-up for RVW-002
Plan: .github/plans/hough-harris-feature-detection-1-foundation.md Pass: plan-bookkeeping closeout
Route standard line detection through the theta/rho accumulator while preserving the legacy SimpleHough.detectLines(...) compatibility surface.\n\nPlan: .github/plans/hough-harris-feature-detection-2-standard-hough-lines.md\nPass: initial implementation
Plan: .github/plans/hough-harris-feature-detection-2-standard-hough-lines.md Pass: plan-bookkeeping closeout
Adds Hough.detectLineSegments(...), the Vision.houghLineSegmentDetection(...) wrapper, and focused probabilistic fixtures/tests. Plan: .github/plans/hough-harris-feature-detection-3-probabilistic-hough-segments.md Pass: initial implementation
Restrict probabilistic duplicate merges to colinear fragments with small along-line gaps, correct merge construction on a shared axis, and add the adjacent-parallel regression requested in review. Plan: .github/plans/hough-harris-feature-detection-3-probabilistic-hough-segments.md Pass: review follow-up Finding: RVW-003
Reject mismatched custom edge-image inputs for probabilistic Hough segments, document the same-size wrapper contract, and add the focused wrapper regression requested in review. Plan: .github/plans/hough-harris-feature-detection-3-probabilistic-hough-segments.md Pass: review follow-up Finding: RVW-004
Record the approved step-3 outcome across the durable packet set, mark the step completed in the plan files, and activate step 4 without absorbing the unrelated Iterate.agent user edit. Plan: .github/plans/hough-harris-feature-detection-3-probabilistic-hough-segments.md Pass: plan-bookkeeping closeout
Add focused standard-Hough regressions for weighted votes, theta-window rejection, and detectLinesFromPoints parity, and record the explicit decision to defer multi-scale srn/stn parity from this step. Plan: .github/plans/hough-harris-feature-detection-4-hough-api-parity.md Pass: initial implementation
Finalize the approved step-4 bookkeeping by recording the normalized approval outcome, activating step 5 in the durable iteration state, and marking the plan set accordingly. Plan: .github/plans/hough-harris-feature-detection-4-hough-api-parity.md Pass: plan-bookkeeping closeout
Introduce the step-5 Hough circle implementation by adding the dedicated detector companion, routing the Hough and Vision circle APIs through it, and covering the new behavior with synthetic fixtures plus focused circle tests. Plan: .github/plans/hough-harris-feature-detection-5-hough-circles.md Pass: initial implementation
Resolve RVW-005 and RVW-006 by scaling Hough circle perimeter sampling with radius, removing the grayscale-as-edge fallback, and adding focused regressions for large-radius and no-edge inputs. Plan: .github/plans/hough-harris-feature-detection-5-hough-circles.md Pass: review follow-up
Record the approved step-5 Hough-circle outcome in the durable packet and progress state, mark the step-5 plan completed, and activate step 6 as the next implementation scope while preserving the unrelated Iterate.agent edit outside the commit. Plan: .github/plans/hough-harris-feature-detection-5-hough-circles.md Pass: plan-bookkeeping closeout
Implement the step-6 Harris response path with grayscale intensity sampling, separable derivative kernels, box or Gaussian local-tensor aggregation, and focused score-ordering regressions that keep synthetic corners above edge interiors and flat regions. Plan: .github/plans/hough-harris-feature-detection-6-harris-response.md Pass: initial implementation
Record the approved step-6 Harris response review in the durable packet, mark the step plan completed, activate step 7 in the ledger and progress note, and preserve the unrelated Iterate.agent user edit outside the commit scope. Plan: .github/plans/hough-harris-feature-detection-6-harris-response.md Pass: plan-bookkeeping closeout
Implement deterministic Harris corner extraction on top of the reviewed response map, expose the public Vision Harris wrappers, add focused corner-selection regressions, record HH-DEC-008, and preserve the unrelated Iterate.agent user edit plus the excluded orchestrator-owned run-ledger update outside the commit scope. Plan: .github/plans/hough-harris-feature-detection-7-harris-corners-and-api.md Pass: initial implementation
Record the approved step-7 review normalization, activate step 8 in the durable packet and progress state, update the plan set, and preserve the unrelated Iterate.agent user edit outside the commit scope. Plan: .github/plans/hough-harris-feature-detection-7-harris-corners-and-api.md Pass: plan-bookkeeping closeout
Refresh the public Vision docs and demo surface, add direct Harris facade coverage, sync the retained GeneratedSuites compatibility registry, and update the manual inventory for the final Hough/Harris closeout while keeping the unrelated Iterate.agent edit and orchestrator-owned run-ledger update out of scope. Plan: .github/plans/hough-harris-feature-detection-8-docs-tests-and-closeout.md Pass: initial implementation
Archive the completed Hough/Harris overview and subplans under .github/realized/, refresh the final queue-exhausted packet, progress, and execution-report state, and keep the unrelated Iterate.agent user edit out of scope. Plan: .github/realized/hough-harris-feature-detection-8-docs-tests-and-closeout.md Pass: queue-exhausted closeout
Plan: .github/plans/manual-review-integration.md Pass: initial implementation
Plan: .github/plans/manual-review-integration.md Pass: review follow-up
Plan: .github/plans/manual-review-integration.md Pass: review follow-up Record 89548ea as the latest committed bookkeeping anchor and adopt MRI-DEC-003 for the current metadata-only response.
Plan: .github/plans/manual-review-integration.md Pass: review follow-up Clarify the iteration workflow contract so the durable packet may stay anchored on 81fd569 while the current response is described separately.
Introduce new markdown templates for commit packets, decision logs, execution reports, implementation handoffs, review packets, run ledgers, and timelines to standardize documentation and facilitate smoother iteration and review workflows. Additionally, create placeholder files for agent progress and plans to enhance project organization.
Archive the completed Hough/Harris overview and all subplans under .github/realized/, update the final queue-exhausted packet, and ensure the unrelated Iterate.agent user edit remains out of scope. Plan: .github/realized/hough-harris-feature-detection-8-docs-tests-and-closeout.md Pass: queue-exhausted closeout
Merge split Hough/Harris modules into single algorithm files, return Ray2D lines and IntPoint2D corners, move visualization out of Hough, add HoughEdgeImageSizeMismatch, document private helpers, and refresh VisionMain demos plus unit tests. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two major feature detection algorithms i wanted to implement for a looooooong time.
This still needs validation.