Minitel: if dest is nil, log the packet and don't send it on#46
Open
LizzyTrickster wants to merge 1 commit into
Open
Minitel: if dest is nil, log the packet and don't send it on#46LizzyTrickster wants to merge 1 commit into
LizzyTrickster wants to merge 1 commit into
Conversation
Member
|
Maybe helpful to throw a debug.traceback into the log too? |
Contributor
Author
|
@XeonSquared will look into adding it. Also thinking we should safeguard against more things being nil (2am is not the time to write software it seems) |
Collaborator
|
I was going to say, but got distracted by factory, yeah you should check
for sender and port also being nil, just to be extra sure
…On Sat, Jan 31, 2026, 09:38 Lizzy ***@***.***> wrote:
*LizzyTrickster* left a comment (ShadowKatStudios/OC-Minitel#46)
<#46 (comment)>
@XeonSquared <https://github.com/XeonSquared> will look into adding it.
Also thinking we should safeguard against more things being nil (2am is not
the time to write software it seems)
—
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA37TWSGDNJTQZLQXY7NTL4JS45FAVCNFSM6AAAAACTQBZHWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMRYGYZTSMBRHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.