Fix Microtel-3 net.send to not naively assume every packet is reliable#44
Open
LizzyTrickster wants to merge 1 commit into
Open
Fix Microtel-3 net.send to not naively assume every packet is reliable#44LizzyTrickster wants to merge 1 commit into
LizzyTrickster wants to merge 1 commit into
Conversation
ACK's are handled in the computer.pullSignal function, but if you're sending a broadcast packet, those cannot be ACK'd by remote systems and are thus send as unreliable packets. If sending an unreliable packet, don't add it to the "awaiting ACK" queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACK's are handled in the computer.pullSignal function, but if you're sending a broadcast packet, those cannot be ACK'd by remote systems and are thus send as unreliable packets. If sending an unreliable packet, don't add it to the "awaiting ACK" queue