pipeline: fix LLM errors in Apache-2.0, MPL-2.0, CC0-1.0 conditions#50
Merged
Conversation
LLM-generated obligations and key_requirements were identical for all
729 licenses ("Include license text", "Include copyright notice").
Replace with _derive_obligations() which builds both fields from the
boolean requirements/permissions/category fields that are already
correct post-correction. Each license now gets obligations that
accurately reflect its actual requirements:
- Retain copyright notices (universal)
- Include license text (universal)
- Document changes (if state_changes)
- Provide source code (if disclose_source)
- Same-license redistribution (if same_license)
- Network-use source disclosure (if network_use_disclosure)
- Restrictions on commercial use / modification / distribution
key_requirements is derived from license category rather than LLM prose.
Apache-2.0: state_changes=False → True (license requires documenting changes made to original files) MPL-2.0: disclose_source=False, same_license=False → both True (file-level copyleft — modified MPL files must stay MPL and source must be made available) CC0-1.0: include_copyright=True, include_license=True → both False (public domain waiver, no copyright or license notice required)
License Check Reportℹ️ No licenses detected in changed files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the
_KNOWN_OVERRIDEStable with three more LLM corrections found during v1.2.9 tarball validation:state_changesFalseTrue— license requires documenting changesdisclose_sourceFalseTrue— file-level copyleft, modified files need source disclosuresame_licenseFalseTrue— modifications must stay under MPLinclude_copyrightTrueFalse— public domain, no notice requiredinclude_licenseTrueFalse— public domain, no notice required