fix: add ~/.steam/debian-installation/ to Steam path detection#134
Open
fernandomema wants to merge 1 commit into
Open
fix: add ~/.steam/debian-installation/ to Steam path detection#134fernandomema wants to merge 1 commit into
fernandomema wants to merge 1 commit into
Conversation
DetectSteamPath() currently searches: 1. ~/.local/share/Steam/ 2. ~/.var/app/com.valvesoftware.Steam/.local/share/Steam/ 3. ~/.steam/steam/ On Debian/Ubuntu systems, Steam installs to ~/.steam/debian-installation/ by default. When this path is missing, accountId fails to bootstrap from loginusers.vdf (returns 0), which causes every cloud hook to fall through to the original Steam function — effectively disabling CloudRedirect for all namespace apps. Add ~/.steam/debian-installation/ as a fallback between the Flatpak path and ~/.steam/steam/, and move the hardcoded default below all known locations.
5dad27c to
2251593
Compare
Owner
|
Oops. Thanks, will review/merge/release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DetectSteamPath()insrc/platform/linux/cloud_intercept.cppcurrently searches these directories (in order):~/.local/share/Steam/~/.var/app/com.valvesoftware.Steam/.local/share/Steam/~/.steam/steam/On Debian/Ubuntu systems (and derivatives like Linux Mint, Pop!_OS, etc.), the Steam package installs to
~/.steam/debian-installation/by default. This path is not in the detection list.When the path is not found,
LoadAccountIdFromLoginUsers()fails to openloginusers.vdf, leavingaccountIdat 0. Every cloud hook then checks:This effectively disables CloudRedirect for all namespace apps — cloud RPCs pass straight through to Steam servers, which return
Upload Access Deniedfor apps that the user doesn't own.Fix
Add
~/.steam/debian-installation/as a fallback between the Flatpak path and~/.steam/steam/. The path is only used when the directory exists, so no change in behavior for other distros.The detection order becomes:
~/.local/share/Steam/(XDG default)~/.var/app/com.valvesoftware.Steam/.local/share/Steam/(Flatpak)~/.steam/debian-installation/(Debian/Ubuntu package)~/.steam/steam/(manual/other)Testing
Confirmed on a Debian-based system where
~/.steam/debian-installation/is the active Steam directory. After applying this fix,accountIdbootstraps correctly fromloginusers.vdfand CloudRedirect intercepts cloud RPCs as expected.