Skip to content

consider all elements and exclude text nodes#1

Open
stefan-langenmaier wants to merge 1 commit into
SeaseLtd:masterfrom
stefan-langenmaier:consider-all-elements-and-exclude-text-nodes
Open

consider all elements and exclude text nodes#1
stefan-langenmaier wants to merge 1 commit into
SeaseLtd:masterfrom
stefan-langenmaier:consider-all-elements-and-exclude-text-nodes

Conversation

@stefan-langenmaier

Copy link
Copy Markdown

I'm not sure if this is the best approach but, in my json model file the weights were sorted after the trees and so I got NPE when importing.

@alessandrobenedetti

Copy link
Copy Markdown
Member

hi @stefan-langenmaier , sorry for the very late reply but I missed this one !
I would be happy to merge the change, but can you provide a unit-test in your Pull Request ?

You can :

  • provide a sample model that is failing for you ( adding it to /ltr-tools/src/test/resources/models/)
  • add a test similar to indexModel_sampleModel_shouldIndexAllModelSplits
  • verify the other tests are not broken

Then we can discuss it and merge it !

Cheers

@stefan-langenmaier

Copy link
Copy Markdown
Author

Hello @alessandrobenedetti

no worries. :) I'll try to work on it next week.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants