Chris/schy 45 datastreamreplicator for python

[cbrady]

No description provided.

[bpapillon]

Can we avoid checking in the wasm file? I remember we had a similar convo about this during one of the last SDKs, my though was that since we have another repo responsible for producing that wasm binary, we should be able to pull it in at build time.

Related - we should probably figure out a way to do some kind of build test, as I'm not certain how the packaging and publishing system here determines which files to include. We need to make sure that the wasm file, however we pull it in, ends up getting shipped with the published Python package.

[bpapillon]

I think our goal here should be to get to feature parity across the SDKs aside from OpenFeature which we can ignore, and parameter defaults which we've discussed separately we can do a sweep after this to get into alignment. So we should implement check_flags here as well.

Also, let's comp the test cases against reference implementations like Node, Ruby, Go - I think we are lighter here.

[bpapillon]

this may be minor enough to do as a followup, but we should make sure we close the _health_check_client http client in DataStreamClient.close so we don't leak the connection pool. probably not a huge issue in practice since DataStreamClient.close is probably only getting called when the service that runs the schematic client singleton is shutting down, but I could see it being a problem in integration tests or things like that where maybe we need to shut down the client in between usages.

[bpapillon]

I always forget that the python client is actually two clients. we should support datastream in the sync client as well

[cbrady]

@bpapillon yeah the reason i didn't add it as part of the SchematicClient is because the datastream functionality is async by nature. there is a way to accomplish it but there are a few issues, many python webservers use fork which would break the thread running the datastream, it adds overhead to the requests (not a ton but enough to note), Exception/traceback quality degrades, and shutdown need to be strictly ordered which could be broken by our customer's own shutdown routines.

[bpapillon]

Ok, I'm fine merging without that support. We do have datastream support in some other clients that have similar issues, so we should probably figure out a way to do this in the sync client at some point, but for now lets just progress and note this in the docs.