fix(tui): align proxy listen port editing with CLI behavior#270
Open
paigeman wants to merge 1 commit into
Open
fix(tui): align proxy listen port editing with CLI behavior#270paigeman wants to merge 1 commit into
paigeman wants to merge 1 commit into
Conversation
- allow editing the selected app proxy listen port while the proxy is running for other apps - keep listen address blocked while the local proxy is running - add active-worker helper for proxy snapshots and reuse it across TUI views and handlers - split address and listen-port stop messages for hints, toasts, and runtime fallback - cover running-proxy editability, active-worker blocking, and submit-time blocking in TUI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TUI proxy settings blocked editing the listen port whenever the local proxy was running.
This was stricter than the CLI behavior. The CLI already allows changing the selected app's preferred proxy listen port while the proxy is running, as long as that app does not currently have an active proxy worker.
This change brings the TUI behavior in line with the CLI:
The TUI copy was also split so address and port guidance describe the correct action.
Changes
src-tauri/src/cli/tui/data.rsProxySnapshot::has_active_worker_for(...)to centralize active-worker checks for an app.routes_current_app_through_proxy(...).src-tauri/src/cli/tui/app/content_config.rssrc-tauri/src/cli/tui/app/overlay_handlers/dialogs.rssrc-tauri/src/cli/tui/runtime_actions/settings.rssrc-tauri/src/cli/tui/ui/config.rssrc-tauri/src/cli/i18n.rssrc-tauri/src/cli/i18n/texts/config_actions.rssrc-tauri/src/cli/tui/app/tests.rssrc-tauri/src/cli/tui/ui/tests.rsCloses #269