add notebooks and improve BS wav build readability#46
Merged
Conversation
Open
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the radial bump-window construction in the 2D bump steerable wavelet (Fourier-domain) to make the width_factor scaling explicit in the support definition, alongside a comment update intended to improve readability/traceability.
Changes:
- Adjusts the bump-window support from
r < 1tor < 1/sqrt(width_factor)to match the subsequentr2 *= width_factorscaling. - Updates the inline comment that references where the
width_factorchoice was numerically validated (notebook name).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
445
to
+448
| # apply bump window over r: g(r) = exp(-r^2 / (1 - r^2)) * 1_{0<r<1} | ||
| r2 = r**2 | ||
| support_r = (r >= 0.0) & (r < 1.0) | ||
| r2 *= width_factor # optimized parameter (for L=4) to follow at best Littlewood Paley condition, see numerical integration in the notebook "BS_wavelet_kernel.ipynb" | ||
| r2 *= width_factor # optimized parameter (for L=4) to follow at best Littlewood Paley condition, see numerical integration in the notebook "consistency_Kernel_FFT.ipynb" | ||
| support_r = (r >= 0.0) & (r < width_factor ** (-0.5)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.