Fix wavelet norm#41
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates wavelet normalization and related scattering/synthesis behavior across the 2D FFT/kernel backends and statistics pipeline.
Changes:
- Adds/updates Bump-Steerable and Morlet wavelet normalization paths.
- Changes kernel backend defaults and smoothing/downsampling behavior.
- Adds synthesis prefiltering/reweighting options and tightens normalization handling.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
STL_main/Synthesis.py |
Adds Nyquist prefiltering and ad-hoc coefficient reweighting to synthesis optimization. |
STL_main/STL_2D_Kernel_Torch.py |
Changes default wavelet type, adds bump-steerable kernels, updates Morlet kernels, smoothing kernels, and downsampling. |
STL_main/STL_2D_FFT_Torch.py |
Adjusts FFT wavelet bank normalization and wavelet type naming. |
STL_main/ST_Statistics.py |
Refactors reference diagonal normalization and batch-mean handling. |
STL_main/ST_Operator.py |
Adds norm validation and updates S4 broadcasting/indexing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| :, N // 2 - w : N // 2 + w + 1, N // 2 - w : N // 2 + w + 1 | ||
| ] # [L, K, K] | ||
| kernel -= kernel.mean(dim=(-2, -1), keepdims=True) | ||
| kernel = kernel.to(device=self.device) |
Contributor
Author
There was a problem hiding this comment.
not sure its necessary
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Contributor
Author
|
@dtibi69 & @jmdelouis la PR est prête pour être mergée, j'attends vos retours ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.