Decouple streak pairs from the mains overlay; harmonics 0 disables mains#30
Merged
Conversation
Field feedback on the just-shipped streak pairs: they were only drawn (and therefore only draggable) while "Show mains-pickup overlay" was on, and the harmonics spin bottomed out at 1 — so using a custom pair forced at least one mains notch into the removal. Mains pickup (electrical noise) and custom streaks (scan-parameter noise, e.g. tip speed) are physically distinct signals; neither should require the other. - "Show streak pairs" checkbox next to the pair controls gates the custom lines independently of the mains overlay; adding a pair switches it on automatically. Hidden pairs no longer capture pan clicks. - The harmonics spin allows 0, and predict_mains_fft_positions returns no predictions for an explicit 0 (previously clamped to 1, silently forcing the fundamental in) — so a custom pair can be applied alone even when the scan speed is known, and the same params replay identically from provenance. Status line reports "Mains notches disabled (harmonics = 0)". Kernel + GUI tests: harmonics=0 prediction contract, custom-streak-only apply leaving the mains fundamental untouched, pair visibility without the overlay, hidden-pair click transparency, and the harmonics-0 apply path. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #28 from field use: custom streak pairs were only visible/draggable while "Show mains-pickup overlay" was on, and harmonics couldn't go below 1 — so applying a streak pair always dragged at least one mains notch along. The two are physically distinct signals (electrical pickup vs scan-parameter noise) and are now fully independent:
predict_mains_fft_positionsreturns[]for an explicit 0 instead of clamping to 1), so streak-pair-only removals work with a known scan speed and replay identically from provenance. Status reports "Mains notches disabled (harmonics = 0)".Test plan
harmonics=0+ the pair.🤖 Generated with Claude Code