Remove fuzz and return face id alongside element id (Replace stale #308)#319
Draft
Sichao25 wants to merge 4 commits into
Draft
Remove fuzz and return face id alongside element id (Replace stale #308)#319Sichao25 wants to merge 4 commits into
Sichao25 wants to merge 4 commits into
Conversation
jacobmerson
reviewed
May 26, 2026
| * should be updated to properly handle the new result. | ||
| */ | ||
| [[nodiscard]] virtual LO GetOwningElementId(const Result& result) const = 0; | ||
| [[nodiscard]] virtual Kokkos::View<LO*> GetOwningElementIds( |
Collaborator
There was a problem hiding this comment.
Can these GetOwningElementId functions be made into free functions?
Contributor
Author
There was a problem hiding this comment.
It is possible, but since we need to access some private members, more API changes such as getter functions are required.
Collaborator
There was a problem hiding this comment.
Ok, so I think we should probably have a free function that given mesh, dim, id gives back the owning element. The member function can call this.
The free function version will be useful in a number of other places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved the merge conflict and updated the PR #308 to fit the new field API.