fix: sanitize adaptive card schema URL

[Artemis-Coder17]

#822
Fixed untrusted schema warning in manifest.json by replacing the external adaptivecards.io reference with the bundled local schema after fetching from GitHub, aligning the online fetch path with the existing bundled fallback behaviour

[changeset-bot]

🦋 Changeset detected

Latest commit: daa2f6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
vscode-ui5-language-assistant	Patch
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[marufrasully]

Thanks @Artemis-Coder17

• Please align on reg https://github.com/SAP/ui5-language-assistant/blob/master/packages/vscode-ui5-language-assistant/scripts/manifest/run-update.ts#L80. You may re-use it as function.
• Please add unit test for this case too
• Please add change file. It must include:
  • "vscode-ui5-language-assistant"
  • "@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext"

Please also note that CI/CD pipline is broken due to remove of ui5 version where our tests depends on it.

[Artemis-Coder17]

Thanks @Artemis-Coder17

• Please align on reg https://github.com/SAP/ui5-language-assistant/blob/master/packages/vscode-ui5-language-assistant/scripts/manifest/run-update.ts#L80. You may re-use it as function.

• Please add unit test for this case too

• Please add change file. It must include:

  • "vscode-ui5-language-assistant"
  • "@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext"

Please also note that CI/CD pipline is broken due to remove of ui5 version where our tests depends on it.

Thanks @marufrasully for the review

I've addressed all the review comments:

• Regex alignment — extracted the adaptivecards.io replacement into a shared sanitizeAdaptiveCardUrl() function in src/utils/index.ts, using the same regex as run-update.ts. Both files now call the shared function.
• Unit tests — added 3 tests for sanitizeAdaptiveCardUrl in utils/index.test.ts and 1 test covering the sanitization flow in manifest-schema-provider.test.ts.
• Changeset Added — Including both vscode-ui5-language-assistant and @ui5-language-assistant/vscode-ui5-language-assistant-bas-ext.

Regarding the CI/CD pipeline failure — as you noted, this is caused by the removal of a UI5 version that the semantic-model tests depend on.

[marufrasully]

@Artemis-Coder17 thanks.

• code looks good
• review comment is addressed

The pipeline is broken due to removal of UI5-version "1.71 which our tests are based on. See https://github.com/SAP/ui5-language-assistant/blob/master/packages/constant/src/constant.ts#L9 we should adapt and use 1.120. See this for available UI5 versions https://ui5.sap.com/versionoverview.html