Skip to content

feat: SAP icons in editor or hover#512

Draft
uxkjaer wants to merge 1 commit into
masterfrom
ui5-icons
Draft

feat: SAP icons in editor or hover#512
uxkjaer wants to merge 1 commit into
masterfrom
ui5-icons

Conversation

@uxkjaer

@uxkjaer uxkjaer commented Oct 21, 2022

Copy link
Copy Markdown
Member

Todo:

  • Settings for showing icons in editor or only on hover
  • Setting to disable icon hover or editor
  • On hover functionality
  • Code completion for icons
  • Update readme with Icons functionality and prerequisite of SAP-icons fonts installed on machine
  • Make tests pass
  • Add integration tests

fixes #509

@uxkjaer uxkjaer added enhancement New feature or request help wanted Extra attention is needed labels Oct 21, 2022
@uxkjaer uxkjaer changed the title feat: icons in editor POC - failing tests feat: SAP icons in editor or hover Oct 21, 2022
@lgtm-com

lgtm-com Bot commented Oct 21, 2022

Copy link
Copy Markdown

This pull request introduces 5 alerts when merging f4effa8 into 352164f - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

@uxkjaer

uxkjaer commented Oct 21, 2022

Copy link
Copy Markdown
Member Author

Should the sap-icon font-family be added to the editor in the extension or should the user set it themselves in the settings?
@petermuessig @bd82

@cla-assistant

cla-assistant Bot commented Oct 18, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

2 similar comments
@cla-assistant

cla-assistant Bot commented Oct 18, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant

cla-assistant Bot commented Oct 18, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code completion for SAP-icons

1 participant