fix: use labelTrue/labelFalse for confirm question breadcrumb labels#548
Merged
Conversation
kjose90
force-pushed
the
bug/questions-label-fix
branch
from
July 1, 2026 13:45
a84768d to
8296662
Compare
kjose90
marked this pull request as ready for review
July 1, 2026 13:51
alex-gilin
requested changes
Jul 3, 2026
Member
Author
|
@alex-gilin Thanks for approving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem -
confirmtype questions supportlabelTrue/labelFalseproperties to customise the displayed answer text, but the breadcrumb rendering in answerUtils.js was ignoring them — always showing the hardcoded"Yes" / "No"strings regardless.Solution - Updated
getTextForAnswerto usequestion.labelTrue/question.labelFalsewhen available, falling back to"Yes" / "No"if not set.Added example to food q generator