[PULL REQUEST] Updating mortality scripts#155
Open
KPHSANDAG wants to merge 7 commits into
Open
Conversation
GregorSchroeder
requested changes
Jul 13, 2026
GregorSchroeder
left a comment
GregorSchroeder
left a comment
Contributor
There was a problem hiding this comment.
We have the data nicely stored in [socioec_data] so let's take advantage of that and do more data processing in SQL server and simplify the Python code.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this pull request. What changes are being made?
This pr changes the source of mortality data from the data folders
data/deathsanddata/undesato thesocioec_datawarehouse containing[vital_statistics].[cdc_wonder_mortality]and[vital_statistics].[undesa_survivors]. Existing scripts indeath_rates.pyhave been modified to account for the source change and new sql files calling the data have been added.Lastly, the streamlit file
3_Rates.pyhas been modified to fit the line length and to assure sorting for the mortality files to prevent issues in visualizations.Validation and testing
Successful run can be seen in [CohortComponentModel].[outputs].[rates] or in the streamlit report where
run_id = 57.What issues does this pull request address?
closes #154
Additional context
N/A