Skip to content

[codex] Fix exception overlay script reload#43

Merged
S1mplector merged 1 commit into
stablefrom
codex/fix-exception-reload
Jun 22, 2026
Merged

[codex] Fix exception overlay script reload#43
S1mplector merged 1 commit into
stablefrom
codex/fix-exception-reload

Conversation

@S1mplector

Copy link
Copy Markdown
Owner

What changed

  • Route the runtime exception overlay Reload button through the real scenario reload path.
  • Reparse the current script and replace the running scene with its updated content.
  • Preserve settings, variables, playback modes, and the nearest available label.
  • Refresh the exception overlay when the updated script still fails to load.

Why

The Reload button previously reset the already-built scenario to node zero and called its lifecycle hook again. It never read the edited script, so fixing the source and pressing Reload appeared to do nothing.

Impact

Developers can correct a runtime or parse error on disk and retry directly from the error overlay without restarting the game.

Validation

  • ./gradlew :fx:test
  • git diff --check

@S1mplector S1mplector marked this pull request as ready for review June 22, 2026 19:58
@S1mplector S1mplector merged commit bf9a76f into stable Jun 22, 2026
1 of 4 checks passed
@S1mplector S1mplector deleted the codex/fix-exception-reload branch June 22, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant