fix(ci): handle grouped release PRs where release-please fails to tag - #23
Merged
Conversation
- Add `npm_tags_created` output to `recover-stale-releases` job so
downstream jobs can detect when the recovery path created tags
- Use `npm_tags_created` as a fallback signal for NPM_PUBLISH alongside
release-please's own `sdk--release_created` output
- Remove `${version}` token requirement from group-pull-request-title-pattern
so validation passes for grouped PRs whose titles omit the version
- Bump examples/todo-react deps to 0.1.7 to align with latest releases
- Improve debug notice to log both RP and recover-path npm signals
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release automation to reliably trigger npm publishing for grouped release PRs when release-please fails to create GitHub Releases, and aligns the todo-react example dependencies with the latest package versions.
Changes:
- Expose a
npm_tags_createdoutput fromrecover-stale-releasesand use it as a fallback signal to publish npm packages whensdk--release_createdis missing. - Relax grouped release PR title pattern requirements by removing the
${version}token and updating the workflow validation accordingly. - Bump
examples/todo-reactapp version and REP package dependencies to0.1.7.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
release-please-config.json |
Adjusts grouped PR title pattern to support grouped releases that omit ${version}. |
examples/todo-react/package.json |
Updates the example app and REP dependency versions to 0.1.7. |
.github/workflows/release-sdk.yml |
Adds a recovery job output and merges it with release-please signals to decide npm publishing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm_tags_createdoutput to therecover-stale-releasesjob so downstream jobs can consume it as a fallback signal when release-please doesn't create a GitHub Release (common with grouped PRs where the merged PR title lacks the${component}token)sdk--release_created) and the recovery signal (npm_tags_created) when deciding whether to publish to npm — either path can trigger a publish${version}token requirement fromgroup-pull-request-title-patternso the validation step doesn't fail for grouped PR titles that omit the versionexamples/todo-reactdeps to0.1.7to align with latest releasesTest plan
recover-stale-releasesjob setsnpm_tags_created=1publish-npmfires via the fallback path whensdk--release_createdis empty butnpm_tags_createdis setexamples/todo-reactbuilds cleanly with the bumped dep versions🤖 Generated with Claude Code