Refactor OfflinePlayerArgument population to avoid blocking the server thread - #686
Open
BestBearr wants to merge 2 commits into
Open
Refactor OfflinePlayerArgument population to avoid blocking the server thread#686BestBearr wants to merge 2 commits into
BestBearr wants to merge 2 commits into
Conversation
Owner
|
Ja @BestBearr Thanks for your pull request! Do we know how much version range this change supports? |
Author
I targeted 1.8 through modern. Personally tested on 1.8.8, 1.21.1, 1.21.4, 1.21.8, and 26.2. |
…Argument population - EXECUTOR type is not implemented on Paper, and I did not want to block the platform executor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bukkit's
Server#getOfflinePlayersmethod being loaded by theOfflinePlayerArgumentcauses a huge strain on servers with large player counts. This pull request moves this work to an executor thread. SincegetOfflinePlayersis not thread-safe, and I want to target as many versions as possible, I opted to use reflection and raw NBT parsing. The Bukkit approach was too inefficient for what we need - which is the last known username so we can cache it.An alternative method that could be used is reading the
usercache.json, but I find this method too unreliable. Some networks (including my own) do not utilize this file anymore.