Skip to content

Fix Netlify deployment and UI issues #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohanExploit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Netlify deployment and UI issues #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"test:coverage": "jest --coverage"
},
"dependencies": {
"dexie": "^4.4.4",
"i18next": "^26.3.6",
"i18next-browser-languagedetector": "^8.2.1",
"lucide-react": "^0.562.0",
"react": "^19.2.0",
"react-dom": "^19.2.0",
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/setupTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import '@testing-library/jest-dom';

// Mock import.meta globally for Jest
global.import = global.import || {};
global.import.meta = {
globalThis.import = globalThis.import || {};

@cubic-dev-ai cubic-dev-ai Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The test setup still does not mock import.meta: assigning globalThis.import.meta creates an unrelated object and cannot change the module import.meta value. Any test or module that reads import.meta outside the existing import.meta.env transform will not receive this env object; use the Jest transform/module-mocking mechanism instead, or remove this misleading setup.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At frontend/src/setupTests.js, line 4:

<comment>The test setup still does not mock `import.meta`: assigning `globalThis.import.meta` creates an unrelated object and cannot change the module `import.meta` value. Any test or module that reads `import.meta` outside the existing `import.meta.env` transform will not receive this `env` object; use the Jest transform/module-mocking mechanism instead, or remove this misleading setup.</comment>

<file context>
@@ -1,9 +1,9 @@
 // Mock import.meta globally for Jest
-global.import = global.import || {};
-global.import.meta = {
+globalThis.import = globalThis.import || {};
+globalThis.import.meta = {
   env: {
</file context>

globalThis.import.meta = {
env: {
VITE_API_URL: 'http://localhost:3000'
}
};
};
3 changes: 3 additions & 0 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
publish = "frontend/dist"
command = "npm install --prefix frontend && npm run build --prefix frontend"

[build.environment]
CI = "false"

@cubic-dev-ai cubic-dev-ai Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The Netlify override does not reliably disable CI behavior: "false" is a non-empty environment string, so tools that use CI truthiness can continue treating the build as CI and still fail on warnings. An empty value is the documented override, or this setting can be removed since the current frontend build script only runs vite build.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At netlify.toml, line 6:

<comment>The Netlify override does not reliably disable CI behavior: `"false"` is a non-empty environment string, so tools that use CI truthiness can continue treating the build as CI and still fail on warnings. An empty value is the documented override, or this setting can be removed since the current `frontend` build script only runs `vite build`.</comment>

<file context>
@@ -2,6 +2,9 @@
   command = "npm install --prefix frontend && npm run build --prefix frontend"
 
+[build.environment]
+  CI = "false"
+
 [[redirects]]
</file context>
Suggested change
CI = "false"
CI = ""


[[redirects]]
from = "/*"
to = "/index.html"
Expand Down
Loading