Mark font-name strings as untranslatable#104
Merged
Merged
Conversation
OpenDyslexic, Ubuntu and Oxygen are proper names and should not be translated. Marking them translatable="false" removes them from the Transifex source resource so they are no longer offered to translators, and stops Android lint flagging them as missing translations per locale. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01UoWHigDqjrL73msxckA91H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
translatable="false"to the three font-name strings inapp/src/main/res/values/strings.xml:font_opendyslexic(OpenDyslexic)font_ubuntu(Ubuntu)font_oxygen(Oxygen)Why
These are proper names and shouldn't be translated (as noted in review on #97, where the hand-translated Dutch versions were removed). Marking them
translatable="false":font_system("System default") stays translatable — only the proper-noun font names are affected. Uses the sametranslatable="false"convention already present inuntranslatable-strings.xml.🤖 Generated with Claude Code
Generated by Claude Code