Skip to content

Reject stale OpenAPI secret bindings before submit#890

Open
dmmulroy wants to merge 1 commit into
RhysSullivan:refactor/unified-provider-architecturefrom
dmmulroy:fix/stale-openapi-secret-bindings
Open

Reject stale OpenAPI secret bindings before submit#890
dmmulroy wants to merge 1 commit into
RhysSullivan:refactor/unified-provider-architecturefrom
dmmulroy:fix/stale-openapi-secret-bindings

Conversation

@dmmulroy
Copy link
Copy Markdown

@dmmulroy dmmulroy commented Jun 4, 2026

Summary

  • add OpenAPI secret binding validation for selected secret id and credential scope
  • block Add OpenAPI submit when a selected secret no longer exists before creating the source
  • cover existing, deleted, and wrong-scope secret selections

Verification

  • bunx oxfmt --check packages/plugins/openapi/src/sdk/secret-binding-validation.ts packages/plugins/openapi/src/sdk/secret-binding-validation.test.ts packages/plugins/openapi/src/react/AddOpenApiSource.tsx
  • bunx oxlint -c .oxlintrc.jsonc --deny-warnings packages/plugins/openapi/src/sdk/secret-binding-validation.ts packages/plugins/openapi/src/sdk/secret-binding-validation.test.ts packages/plugins/openapi/src/react/AddOpenApiSource.tsx
  • bun run --cwd packages/plugins/openapi test -- src/sdk/secret-binding-validation.test.ts
  • bun run --cwd packages/plugins/openapi typecheck

@dmmulroy dmmulroy force-pushed the fix/stale-openapi-secret-bindings branch from 32f24bf to d9e5a5a Compare June 4, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant