Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/effect-peer-dependency.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"executor": patch
---

Move `effect` from `dependencies` to `peerDependencies` (with a `devDependencies` mirror) in the published library packages.

`effect` relies on a single module instance for `Context`/service identity and type equality. Declaring it as a hard dependency lets consumers end up with duplicated `effect` copies — e.g. an app on a newer `4.0.0-beta.x` installed alongside these packages' pinned version — which breaks service resolution and surfaces as TypeScript reporting the two `effect` copies as incompatible.

Declaring `effect` as a peer dependency lets the consuming app supply the single shared `effect` version. Consumers now need `effect` as a direct dependency. Private workspace packages and the `executor` CLI keep `effect` as a regular dependency.
48 changes: 36 additions & 12 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion packages/core/config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,19 @@
},
"dependencies": {
"@executor-js/sdk": "workspace:*",
"effect": "catalog:",
"jiti": "^2.6.1",
"jsonc-parser": "^3.3.1"
},
"devDependencies": {
"@effect/platform-node": "catalog:",
"@effect/vitest": "catalog:",
"@types/node": "catalog:",
"effect": "catalog:",
"tsup": "catalog:",
"typescript": "catalog:",
"vitest": "catalog:"
},
"peerDependencies": {
"effect": "catalog:"
}
}
7 changes: 5 additions & 2 deletions packages/core/execution/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,19 @@
},
"dependencies": {
"@executor-js/codemode-core": "workspace:*",
"@executor-js/sdk": "workspace:*",
"effect": "catalog:"
"@executor-js/sdk": "workspace:*"
},
"devDependencies": {
"@effect/vitest": "catalog:",
"@executor-js/runtime-quickjs": "workspace:*",
"@types/node": "catalog:",
"bun-types": "catalog:",
"effect": "catalog:",
"tsup": "catalog:",
"typescript": "catalog:",
"vitest": "catalog:"
},
"peerDependencies": {
"effect": "catalog:"
}
}
3 changes: 2 additions & 1 deletion packages/core/sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
},
"dependencies": {
"@standard-schema/spec": "^1.1.0",
"effect": "catalog:",
"fractional-indexing": "^3.2.0",
"fumadb": "workspace:*",
"oauth4webapi": "^3.8.5"
Expand All @@ -87,6 +86,7 @@
"@types/react": "catalog:",
"better-sqlite3": "^12.9.0",
"drizzle-orm": "catalog:",
"effect": "catalog:",
"react": "catalog:",
"tsup": "catalog:",
"typescript": "catalog:",
Expand All @@ -95,6 +95,7 @@
"peerDependencies": {
"@effect/atom-react": "catalog:",
"@effect/platform-node": "catalog:",
"effect": "catalog:",
"react": "catalog:"
},
"peerDependenciesMeta": {
Expand Down
5 changes: 4 additions & 1 deletion packages/kernel/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,18 @@
"@standard-schema/spec": "^1.0.0",
"ajv": "^8.17.1",
"ajv-formats": "^3.0.1",
"effect": "catalog:",
"sucrase": "^3.35.1"
},
"devDependencies": {
"@effect/vitest": "catalog:",
"@types/node": "catalog:",
"bun-types": "catalog:",
"effect": "catalog:",
"tsup": "catalog:",
"typescript": "catalog:",
"vitest": "catalog:"
},
"peerDependencies": {
"effect": "catalog:"
}
}
5 changes: 4 additions & 1 deletion packages/kernel/runtime-quickjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,18 @@
},
"dependencies": {
"@executor-js/codemode-core": "workspace:*",
"effect": "catalog:",
"quickjs-emscripten": "catalog:"
},
"devDependencies": {
"@effect/vitest": "catalog:",
"@types/node": "catalog:",
"bun-types": "catalog:",
"effect": "catalog:",
"tsup": "catalog:",
"typescript": "catalog:",
"vitest": "catalog:"
},
"peerDependencies": {
"effect": "catalog:"
}
}
Loading
Loading