build: replace the package icon and release 1.0.2 - #13
Merged
Conversation
The lighthouse came from Flaticon under a licence requiring the design to be credited wherever it appears, and a NuGet package icon carries no credit line of its own -- the README had to carry it on the package's behalf. It is replaced by a glowing orb, what SignalMe actually lights up, which the project owns outright. The attribution section existed only for that credit, so it goes too, in both READMEs. The icon is committed exactly as authored, 512 px and 318 KB. Nothing in the build derives or rewrites it, which is why make-icon.py goes: it drew the old lighthouse from vector primitives and would now only produce a design the project no longer uses. The development guide carries what is left that matters -- an icon over 1 MB is rejected by nuget.org at publish time, long after CI has gone green. Version bumped to 1.0.2. A published package is immutable, so the icon needs a release of its own. Same tool, same commands, same behaviour, no code changed. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01FnHDBiBvHpiWPAd4YjpykU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 1.0.1 lighthouse came from Flaticon, under a licence requiring the design to be credited wherever it appears. A NuGet package icon carries no credit line of its own, so the README had to carry that credit on the package's behalf.
It is replaced by a glowing orb — what SignalMe actually lights up — which the project owns outright. Nothing in the package depends on anyone else's terms any more, so the attribution section goes with it in both READMEs: it existed only to carry that credit.
The icon
assets/icon.pngis committed exactly as authored — same blob asassets/orb.pngonreefact/new-icon(71ed8a4), not one byte touched.Checked composited on white and on dark at 512 / 128 / 64 / 32 px: it reads on both listing backgrounds and still holds together small.
build/make-icon.pyis removedIt drew the lighthouse from vector primitives. The icon is a committed image now, not a generated one, so a generator that still produces the old design would only mislead whoever runs it. What was worth keeping moves to the development guide: a replacement icon has to stay under 1 MB, because nuget.org rejects a heavier one at publish time — long after CI has gone green.
Release
Versiongoes to 1.0.2. A published NuGet package is immutable, so a new icon needs a release of its own. Same tool, same commands, same behaviour — no code changed.CHANGELOG.md/CHANGELOG-FR.md: 1.0.2 entries and compare linksdocs/development.md/docs/development-FR.md: rewritten Assets section, local-install example bumped to 1.0.2Verification
assets/icon.pngverified byte-identical to the source file viagit hash-objectdotnetbuild not run locally:global.jsonpins SDK 10.0.302 and only 10.0.110 is available in this environment. CI runs on Windows with the pinned SDK, andbuild/Validate-Package.ps1asserts the icon reaches the package.After merge, tag
v1.0.2to publish.Generated by Claude Code