build: adopt NuGet Central Package Management#94
Merged
Conversation
Move every PackageReference version into a single Directory.Packages.props (ManagePackageVersionsCentrally=true). This makes the `dotnet restore` steps in the CI and release workflows reproducible, which is what OpenSSF Scorecard's Pinned-Dependencies check credits: the two previously unpinned nugetCommand dependencies (the ci.yml and release.yml restores) now count as pinned, lifting that check from 7 toward 10. Two deliberate exceptions preserve existing behaviour: - FirstClassErrors.Analyzers keeps its Roslyn load-contract floor via VersionOverride="$(RoslynFloorVersion)", independent of the newer central Microsoft.CodeAnalysis.CSharp version the analyzer tests use. - tools/floor-check/FloorCheck.csproj opts out of CPM: it consumes the FirstClassErrors package at a dynamic $(FloorCheckVersion), built in isolation outside the solution. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_014W1zrcBNy3jEs8ngAQKwZg
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt NuGet Central Package Management (CPM): every package version now lives in a single
Directory.Packages.props. Beyond version consistency across projects, this makes thedotnet restoresteps reproducible, which lifts OpenSSF Scorecard's Pinned-Dependencies check — its twodotnet restorecommands (inci.ymlandrelease.yml) were previously flagged as unpinnednugetCommanddependencies, capping the check at 7/10.Type of change
Changes
Directory.Packages.props(ManagePackageVersionsCentrally=true) with a<PackageVersion>for every package used in the solution.Version=from every<PackageReference>across the solution projects.FirstClassErrors.Analyzers: kept the Roslyn load-contract floor viaVersionOverride="$(RoslynFloorVersion)", so it stays property-driven and independent of the newer centralMicrosoft.CodeAnalysis.CSharpversion the analyzer tests consume.tools/floor-check/FloorCheck.csproj: opted out of CPM (ManagePackageVersionsCentrally=false) — it consumes theFirstClassErrorspackage at a dynamic$(FloorCheckVersion)and is built in isolation, outside the solution.Testing
dotnet build FirstClassErrors.sln(Release, with the CI warning ratchet — 0 warnings)dotnet test FirstClassErrors.sln(Release — 598 passed, 0 failed)FirstClassErrors.Analyzers.UnitTests—RoslynFloorTestsconfirms the analyzer floor is unchanged)Documentation
doc/updateddoc/README.fr.md) updated if user-facing behavior changedDirectory.Packages.propscarries an explanatory header comment; no user-facing behavior changes.Related issues
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_014W1zrcBNy3jEs8ngAQKwZg
Generated by Claude Code