chore: remove dead SipserReduceToCliqueStandard solver path#113
Open
wrigjl wants to merge 1 commit into
Open
Conversation
The backend endpoint that would have surfaced "CliqueBruteForce - via SipserReduceToCliqueStandard" as a solver option was commented out, making the frontend code handling it unreachable. Remove the two dead functions (requestSolvedInstanceTemporarySat3CliqueSolver, requestSolvedVisualization), replace the call site in SolveRowReact with requestSolvedInstance directly, and drop the matching ternary in useSolverInfo. The SipserReduceToCliqueStandard reduction itself is unchanged and still in use. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestSolvedInstanceTemporarySat3CliqueSolverfromcomponents/redux/index.js— the"CliqueBruteForce - via SipserReduceToCliqueStandard"branch was unreachable because the backend endpoint (Nav_Solvers.cs) that would have surfaced that solver option is commented out.requestSolvedVisualizationfromcomponents/redux/index.js— never imported or called anywhere in the frontend.components/pageblocks/SolveRowReact.jswithrequestSolvedInstancedirectly (same signature, was the else-branch anyway).components/hooks/ProblemProvider/Solver.js(useSolverInfo), passingsolverstraight touseGenericInfo.The
SipserReduceToCliqueStandardreduction itself (Reduce row when 3SAT is selected) is untouched.3 insertions, 64 deletions.
Test plan
npm run build).🤖 Generated with Claude Code