chore: migrate ESLint to flat config and add SARIF scanning#110
Merged
wrigjl merged 2 commits intoJun 17, 2026
Merged
Conversation
Replace .eslintrc.json with eslint.config.js (ESLint flat config format) and update the lint script to invoke eslint directly since next lint was removed in Next.js 16. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Rename codeql.yml to code-analysis.yml and add an eslint job that runs ESLint with SARIF output for upload to GitHub Security tab. Also ignore the generated eslint-results.sarif artifact. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslintrc.jsonwitheslint.config.js(ESLint 9 flat config format), required for ESLint 10 compatibility when upstream parser support landslintscript fromnext lint(removed in Next.js 16) toeslint .codeql.yml→code-analysis.ymland adds aneslintjob that uploads results to the GitHub Security tab via SARIFeslint-results.sarifto.gitignoreNotes
ESLint 10 was investigated but blocked by
@babel/eslint-parser(bundled in Next.js) and@typescript-eslintnot yet implementingaddGlobalsrequired by ESLint 10. Tracked upstream at babel/babel#17791 and typescript-eslint/typescript-eslint#11829. This flat config migration means bumping to ESLint 10 will be a one-line change once those are resolved.Test plan
npm run lintruns ESLint and reports findingsnpx eslint . --format @microsoft/eslint-formatter-sarif --output-file eslint-results.sarifproduces a valid SARIF file🤖 Generated with Claude Code