Fix if_exists check for non 0 if_exists codes#3
Open
Tortuginator wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for your work! I just tested your tool and came across a small bug with some oddly configured Entra ID accounts that have an
if_existscode of 8, which maps toExistsInAcma. Your code previously handled these users the same as users that did not exist.I fixed it so that users with the
if_existsstatesExists/ExistsBothIDPs/ExistsInOtherMicrosoftIDP/ExistsInAcmaare treated as existing, and their authentication methods are shown properly. This is analogous to how the JavaScript signin client treats these states.Cheers!