Skip to content

Fix DailyQuestSystem quest replenishment and TestQuestFactory creation - #24

Merged
Red-Cat-Fat merged 2 commits into
codex/add-tests-for-all-packages-in-github-actionsfrom
codex/fix-dailyquestsystem-test-failures
Feb 13, 2026
Merged

Fix DailyQuestSystem quest replenishment and TestQuestFactory creation#24
Red-Cat-Fat merged 2 commits into
codex/add-tests-for-all-packages-in-github-actionsfrom
codex/fix-dailyquestsystem-test-failures

Conversation

@Red-Cat-Fat

Copy link
Copy Markdown
Owner

Motivation

  • Tests expecting correct active-quest replenishment, removal on skip/finish, and correct load behavior failed due to ActiveQuests not being initialized and removal logic incorrectly forcing state transitions.

Description

  • Initialize DailyQuestSystem with LoadData(QuestsDataContainer.Empty) in the constructor so the active quest list is populated to the required count at creation. (updated DailyQuestSystem.cs)
  • Change removal flow in UpdateQuestList to unsubscribe from events first and call Disable() only when the quest is still InProgress, avoiding redundant state transitions for already skipped/finished/failed quests. (updated DailyQuestSystem.cs)
  • Implement TestQuestFactory.MakeNewQuest(List<IQuest>) to delegate to the internal test queue method MakeNewQuest() so test factory can supply quests to the system without throwing NotImplementedException. (updated TestQuestFactory.cs)

Testing

  • No Unity/NUnit tests were executed because a Unity test runner is not available in this environment, so automated tests could not be run here and therefore have no pass/fail result.
  • Basic repository checks were performed (git commit, git show) and succeeded, and the changes were committed as part of a local commit.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Red-Cat-Fat
Red-Cat-Fat merged commit de0db5f into codex/add-tests-for-all-packages-in-github-actions Feb 13, 2026
2 checks passed
@Red-Cat-Fat
Red-Cat-Fat deleted the codex/fix-dailyquestsystem-test-failures branch February 13, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant