FINITO Link#128
Open
mmowers wants to merge 27 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a linkage to the FINITO model, which is currently a private repository at https://github.com/NatLabRockies/FINITO). The linkage allows the full electricity sector detail of the ReEDS model to be used in combination with the industrial (and other) sector representation of the FINITO model.
The linkage is turned off by default, so this PR itself should not have impact on ReEDS results (although very small differences were observed in out years, presumably because the ReEDS model itself was touched, even if the matrix is identical).
For a high-level overview of FINITO and the linkage points see this slide deck.
See companion FINITO PR: https://github.com/NatLabRockies/FINITO/pull/438
Technical details
Turning on the linkage adds the constraints of the FINITO model to those of the ReEDS model, and adds the two objective functions together.
To turn on the linkage, clone the FINITO model and checkout the
bs/reeds_link2branch, unless this branch has already been merged intomain, at which pointmain.Configure these switches:
GSw_FINITO_Link: This switch turns on the linkagefinito_dir: This switch needs to point to the FINITO directory as a complete, absolute pathfinito_cases_file: This switch should be the suffix of the cases file in the FINITO directory, which contains the corresponding FINITO scenario configurationfinito_case: This switch is the specific case infinito_cases_fileto be runfirst_year_finito: This switch is the first year that the linkage will be implementedThe reeds2 conda environment should be used for the linked model
Linked runs result in the the same set of ReEDS outputs, but new outputs are also added from FINITO in the
finitosubdirectory of the run directory.Relevant sources or documentation
FINITO documentation is at https://github.com/NatLabRockies/FINITO
Validation, testing, and comparison report(s)
A comparison was made berfore and after this change. There was expected to be no change, but apparently adding parameters to the model (e.g. the tfuel(t) parameter) that should not change the original matrix can still result in very small differences (reduced comparison report here:
reeds_report.zip
):
Checklist for author
Details to double-check
hourlize/resource.pywas rerun to regenerate the existing/prescribed VRE capacity dataGeneral information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Tag points of contact here if you would like additional review of the relevant parts of the model