Update conda environment#103
Open
patrickbrown4 wants to merge 64 commits into
Open
Conversation
…inancials_tech pivot
…ts from assemble_supplycurve() are floats
…estamps() -> parse_h5_timestamps() and allow for either strings or bytes
…or z134, and because PRAS can't handle 1-zone systems
patrickbrown4
commented
Jul 10, 2026
Contributor
Author
There was a problem hiding this comment.
In the end these changes probably weren't necessary, but they were helpful for debugging (and make future updates very slightly easier), so I left them - let me know if you think they should be reverted
patrickbrown4
commented
Jul 10, 2026
| endyear,2032,,2050,2050,2050,2029,2060,2026,,,,,,,,,,,2035,2030,2030,2060,2035,2050,2050,,,,, | ||
| yearset,,,,,,,2010..2060..10,,,,,,,,,,,,,2010..2050..5,2010..2050..5,2010..2060..10,,,2010_2025_2050,,,,, | ||
| GSw_ZoneSet,,,,,,,z54,z3109,,,,,,,z3109,z3109,z3109,PJMcounty,,,,z54,,z54,z48,,,,, | ||
| GSw_ZoneSet,,,,,,,z54,z3109,,,,,,,z3109,z3109,z3109,PJMcounty,,,,z54,z134,z54,z48,,,,, |
Contributor
Author
There was a problem hiding this comment.
Most minimal way to keep Simple working and maintain the original intent (since ReEDS2PRAS doesn't work for single-zone systems)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the conda environment to use new features in
gdxpdsandgeopandas. The main changes are:.simplify_coverage(), which speeds up all the geospatial analysis and plotting (which has been slow since Update interzonal transmission costs/distances and use directly calculated values #95, especially incompare_cases.py)Thanks a lot to @mmowers for taking care of the bokeh update!
Technical details
Implementation notes
Almost all of the code changes are related to pandas 3. The main things to look out for in new code are:
.groupby()no longer accepts anaxisargument, so all the uses ofdf.groupby(axis=1).something()are nowdf.T.groupby().something().T.fillna(method='ffill')(and analogous) is now just.ffill()Additional changes
While working on debugging
calc_financial_inputs.py, I simplified theinputs/financials/financials_tech_*.csvfiles by removing the country column and non-USA entries. They weren't complete anyway, and Canada/Mexico haven't worked since I've been here, so since it simplifies the process for adding new techs, I've kept the change even though it might not actually be required.Validation, testing, and comparison report(s)
Changes for USA_default are nonzero but quite small: results-v20260708_mainK0_USA_defaults,v20260708_envK0_USA_defaults.pptx
I'll go through the rest of these before merging:
reeds_to_rev.py(currently broken; will be addressed by Updates to reeds_to_rev and land_use_analysis #6)Checklist for author
Details to double-check
General information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
No