test: cover ErrorFormatter classify, transport seam, and path edges

[cursor]

Summary

Nightly test-coverage run targeting the Jul 16 scraper refactor (c7f46b8), which extracted ErrorFormatter, LiveBoardApi, DownloadTask, and path helpers but left several new code paths without direct regression tests.

Risky behavior now covered

• ErrorFormatter.classify — category routing for connection, timeout, rate-limit (429), access (403/404), generic HTTP, redirect loops, and unknown errors
• LiveBoardApi transport seam — safe_get wiring for thread/catalog fetch and streaming range requests (default download timeout)
• Redirect hardening — TooManyRedirects on redirect loops; retry when Location header is missing
• Path builder edges — limit_folder_length, catalog/empty-board session naming
• DownloadTask — frozen progress payload schema used by workers

Test files added/updated

• tests/test_error_format.py (new)
• tests/test_transport_api.py (new)
• tests/test_signals.py (new)
• tests/test_session.py (redirect loop + missing Location)
• tests/test_paths.py (limit_folder_length + session base names)

Why these tests materially reduce regression risk

The scraper refactor moved error classification and network access behind new seams. Failures there affect every download path (rate-limit backoff, user-facing messages, redirect security). Direct unit tests on the extracted modules catch regressions without standing up a full FourChanScraper or GUI worker.

Testing performed

• uv run ruff check on touched test files
• uv run pytest tests/ -q --ignore=tests/test_gui.py — 97 passed
• Manual run on macOS / Apple Silicon

Safety notes

Test-only change; no production behavior modified.

Screenshots

N/A — no UI changes.

  

[RazorBackRoar]

Closing as superseded cleanup.

main already contains the needed CI/docs/test fixes. This was an automated draft autofix PR and is no longer needed.