Refactor/frontend theme tokens - #352
Merged
Merged
Conversation
Every menu, panel, modal, and message used its own ad-hoc palette (Backpack blue, Bookshelf/Brain brown, Casino teal, Inbox gray, the light-cyan map info boxes, etc.). Unify them all onto a single slate + amber design system and extract the whole palette into semantic tokens so Bermudia can be re-skinned from one place. - Add a semantic theme palette in styles/main.css (@theme): surface, content, accent, semantic states (success/warning/danger/info[/-alt]), brand (login), and decorative (book spines, inventory-meter gradients, scene backdrop/sky). These generate Tailwind utilities (bg-surface, text-accent, border-danger, bg-danger-soft, ...). - Add shared .panel* component classes for panel/modal chrome. - Rewrite every component/page to reference the tokens instead of raw slate/amber/green/... utilities or hardcoded hex; no raw palette values remain in components. Re-theming is now a single-block edit in main.css followed by a rebuild. Build passes; lint clean (pre-existing warnings only). Co-Authored-By: Claude Opus 4.8 <[email protected]>
The inbox (and any scrollable panel) never became scrollable: its
messages were flex items in the .panel-body column and shrank to fit,
collapsing into thin overlapping lines when the box held more than fit
at once — so no message was readable.
- Bound the panel: add min-height:0 / max-height:100% / overflow:hidden
to .panel so its max-h-[80vh] cap is enforced inside VueFinalModal's
centering flexbox.
- Stop children from shrinking: .panel-body > * { flex-shrink: 0 } so
items keep their natural height and the body scrolls.
Verified in a headless browser with 15+ inbox messages at a constrained
height: body scrollHeight 2064 vs clientHeight 293, scrollable, items at
full height, no overlap; scrollTop responds.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.