Polkadot v1.24.0 stable2606#2948
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny: 16-day-old account with 0 public repos, mitigated by repository write access, corporate commit identity, and no Gittensor association; polkadot-v1.24.0 → main. Static analysis covered the commit-pinned Polkadot SDK upgrade, lockfiles and toolchain, runtime and consensus adaptations, drand authorization, shielded-extrinsic validation, transaction-fee handling, and vendored Frontier. The runtime specification version is bumped, and no protected review-control files were modified. FindingsNo findings. ConclusionThe changes remain consistent with the stated SDK upgrade. No concrete security vulnerability or malicious behavior was found. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 UNKNOWN Gittensor association; author has repository write access but a very new account, so this broad SDK upgrade received heightened scrutiny. The stable2606 compatibility changes are coherent across consensus wiring, authorized drand transactions, lazy-block runtime APIs, transaction-fee credits, shielded-extrinsic inspection, and vendored Frontier. The runtime The overlapping PRs concern unrelated features or fixes despite sharing common files. No auto-fix was needed. FindingsNo findings. ConclusionNo substantive domain issue was identified. Given the breadth of the dependency upgrade, the complete repository CI suite should pass before merge. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
Upgrade Subtensor from the previous RaoFoundation Polkadot SDK revision to the Polkadot v1.24.0 stable2606 revision, keeping the node, runtime, pallets, SDK, and vendored Frontier integration compatible with the updated APIs.
Changes
ExtrinsicCallwhile retaining signature validation.Files of interest
Cargo.toml,Cargo.lock,rust-toolchain.tomlnode/src/consensus/node/src/command.rsruntime/src/lib.rspallets/shield/src/lib.rspallets/transaction-fee/src/lib.rsvendor/frontier/Behavioral impact
This is primarily an SDK compatibility upgrade. Consensus initialization and block import use the stable2606 APIs, runtime execution accepts lazy blocks, and nodes retain the SDK’s default heap strategy. No intentional change to Subtensor economic policy or extrinsic semantics is introduced.
Runtime and migration implications
The runtime code and dependencies change, so the runtime
spec_versionis bumped from 432 to 433. No storage migration is introduced.Validation
The complete repository CI suite, including formatting, compilation, pallet/runtime tests, and runtime build checks, should pass before merge.