Skip to content

[release/internal/3.7.x] Use Cmake 4.0 - #955

Closed
jithunnair-amd wants to merge 2 commits into
ROCm:release/internal/3.7.xfrom
jithunnair-amd:patch-1
Closed

[release/internal/3.7.x] Use Cmake 4.0#955
jithunnair-amd wants to merge 2 commits into
ROCm:release/internal/3.7.xfrom
jithunnair-amd:patch-1

Conversation

@jithunnair-amd

@jithunnair-amd jithunnair-amd commented Jul 21, 2026

Copy link
Copy Markdown

Updating Cmake version to 4.0, similar to #926

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because FILL THIS IN.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

@naromero77amd

Copy link
Copy Markdown

@naromero77amd naromero77amd changed the title Use Cmake 4.0 [release/internal/3.7.x] Use Cmake 4.0 Jul 21, 2026
@jithunnair-amd

Copy link
Copy Markdown
Author

Closing this PR as it only seemed to affect the ROCm/pytorch pytorch-ci-pipeline, since it was trying to build triton using cmake 4.0.0. It looks like theRock CI doesn't impose the same constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants