[release/2.13] Advance Triton pin to 3.8.x branch tip - #3467
Conversation
Co-authored-by: Cursor <[email protected]>
|
Triton 3.8 bump fixes over 100 unit tests (mostly flex_attention) on MI450, more details here: https://github.com/ROCm/frameworks-internal/issues/17274#issuecomment-4986171237 NOTE: Results below are on MI300. Adding the all-Inductor regression analysis from the Triton 3.8 validation run. Triton 3.8 vs Triton 3.7 Regression AnalysisBaseline: Triton 3.7.1 all-Inductor result from the validation artifacts, using Comparison: Triton 3.8.0 from Important caveat: Summary
xychart-beta
title "Failed tests by Triton version"
x-axis ["Triton 3.7.1", "Triton 3.8.0"]
y-axis "Failed tests" 0 --> 120
bar [95, 97]
pie showData
title Triton 3.8 failure delta vs 3.7
"Unchanged failures" : 98
"New failures" : 2
"Resolved failures" : 0
InterpretationTriton 3.8.0 is very close to the Triton 3.7.1 baseline for the full all-Inductor suite on PyTorch 2.13. Total failures increased from 95 to 97, with errors unchanged at 3 and no timeouts or missed tests in either run. There are 2 new failing tests and 0 resolved failures. Suite-Level Regressions
New failing tests:
Suite-Level ImprovementsNo suite-level improvements. Resolved tests:
Unchanged Failing Suites
Source validation thread: naromero77amd/framework_scripts#2 (comment) Related draft PR: #3467 Local artifacts:
|
|
Building with theROCk CI, the build succeeds this was only with the gfx94X-dcgpu. Note that test_torchinductor.py is not included in the github actions workflow test matrix. |
Summary
ROCm/tritonrelease/internal/3.8.x..ci/docker/triton_version.txtfrom3.7.1to3.8.0.Triton pin:
4cff872ced001ea92d9fcf05b3f6517e2b486d19Triton branch:
ROCm/triton@release/internal/3.8.xTest plan
git diff --check -- .ci/docker/ci_commit_pins/triton.txt .ci/docker/triton_version.txt__version__ = '3.8.0'Follows the structure of #3451.
Made with Cursor